search

mljs / random-forest

Random forest for classification and regression.
https://mljs.github.io/random-forest/
MIT License
61 stars 21 forks source link

Fixed issues 9, 15, 17, 28, 32 #38

Closed aiday-mar closed 2 years ago

aiday-mar commented 2 years ago

The variable this.gainThreshold in the TreeNode implementation was not initialized properly and this was leading to an incorrect creation of regression tree. This will be adressed in a separate pull request for the ml-cart module.

Added the possiblity to change the number of samples one wants to use in the training phase

Added a function featureImportance in order to compute the feature importance as was suggested by @xdadda

codecov[bot] commented 2 years ago

Codecov Report

Merging #38 (055de2d) into master (229e93a) will increase coverage by 2.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   91.38%   93.57%   +2.18%     
==========================================
  Files           4        4              
  Lines         209      280      +71     
  Branches       36       64      +28     
==========================================
+ Hits          191      262      +71     
  Misses         17       17              
  Partials        1        1
Impacted Files Coverage Δ
src/RandomForestClassifier.js 95.45% <ø> (+0.10%) :arrow_up:
src/RandomForestRegression.js 87.50% <ø> (+0.54%) :arrow_up:
src/RandomForestBase.js 95.13% <100.00%> (+6.38%) :arrow_up:
src/utils.js 91.17% <100.00%> (-2.48%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 229e93a...055de2d. Read the comment docs.