mljs / regression-robust-polynomial

Robust polynomial regression using LMedS
https://mljs.github.io/regression-robust-polynomial/
MIT License
4 stars 2 forks source link

eslint-plugins #4

Closed lpatiny closed 2 years ago

lpatiny commented 2 years ago

@targos I'm a little bit lost and I don't know what I did wrong because I had to put back the eslint-plugins other the test failed.

https://github.com/mljs/regression-robust-polynomial/commit/d0f1c9f27db099bbc44367ae5f0ee2cf4c68da5e

ESLint: 7.32.0

ESLint couldn't find the plugin "eslint-plugin-jest".

(The package "eslint-plugin-jest" was not found when loaded as a Node module from the directory "/Users/lpatiny/git/mljs/regression-robust-polynomial".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install eslint-plugin-jest@latest --save-dev

What did I do wrong ?

targos commented 2 years ago

I don't have this problem, so I pushed 78c7cb53712659a06a8ef218af0a23ce2fdfbcdc. But it's perfectly fine to depend directly on the plugins. It's just not mandatory anymore with npm 7+ Note that if you were testing with ESLint 8, it is expected to not work out of the box, as the eslint-plugin-jest doesn't support ESLint 8 yet.