search

mljs / spectra-processing

Various methods to help spectra processing
https://mljs.github.io/spectra-processing/
MIT License
7 stars 12 forks source link

feat: enable FFT for xHilbertTransform to enhance speed for arrays with lengths that are powers of 2 #198

Closed josoriom closed 11 months ago

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (570147c) 91.56% compared to head (8f9e905) 91.66%. Report is 3 commits behind head on main.

:exclamation: Current head 8f9e905 differs from pull request most recent head c54d322. Consider uploading reports for the commit c54d322 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #198 +/- ## ========================================== + Coverage 91.56% 91.66% +0.10% ========================================== Files 165 166 +1 Lines 3236 3275 +39 Branches 818 822 +4 ========================================== + Hits 2963 3002 +39 Misses 266 266 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

targos commented 11 months ago

You need to explain the breaking change in the commit message (see the conventional commit spec) and not use "!" unless the title is already clear about what's breaking

josoriom commented 11 months ago

You need to explain the breaking change in the commit message (see the conventional commit spec) and not use "!" unless the title is already clear about what's breaking

Thanks, I'll remember that!

lpatiny commented 11 months ago

There is no breaking change and speed improvement so it is great to me. However I'm still wondering if we could do a trick that allows to always use FFT.