search

mljs / spectra-processing

Various methods to help spectra processing
https://mljs.github.io/spectra-processing/
MIT License
7 stars 12 forks source link

feat: Allow xHilbertTransform to use FFT for array lengths non power of 2 close #202 #203

Closed josoriom closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fdeca70) 91.74% compared to head (bf335ed) 91.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #203 +/- ## ========================================== + Coverage 91.74% 91.79% +0.05% ========================================== Files 168 168 Lines 3308 3329 +21 Branches 826 829 +3 ========================================== + Hits 3035 3056 +21 Misses 266 266 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

josoriom commented 10 months ago

Don't you need to resize the output array after the operation?

Please add test(s).

@targos Yes, it's solved!