search

mljs / spectra-processing

Various methods to help spectra processing
https://mljs.github.io/spectra-processing/
MIT License
7 stars 12 forks source link

improve reimautophasecorrection by removing outliers #206

Closed jobo322 closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (041c639) 91.67% compared to head (a02f770) 94.97%.

:exclamation: Current head a02f770 differs from pull request most recent head d70da2c. Consider uploading reports for the commit d70da2c to get more accurate results

Files Patch % Lines
src/reim/reimAutoPhaseCorrection.ts 84.37% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #206 +/- ## ========================================== + Coverage 91.67% 94.97% +3.29% ========================================== Files 168 168 Lines 3290 3301 +11 Branches 825 826 +1 ========================================== + Hits 3016 3135 +119 + Misses 267 163 -104 + Partials 7 3 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jobo322 commented 10 months ago

Please fix the order of imports (and configure your IDE to run ESLint on save).

I can't review the algo as I have no idea what this is about.

Many thanks, I did setup the IDE for auto-eslint fixing.