search

mljs / spectra-processing

Various methods to help spectra processing
https://mljs.github.io/spectra-processing/
MIT License
7 stars 12 forks source link

feat: add matrixSetSubMatrix #211

Closed jobo322 closed 8 months ago

jobo322 commented 8 months ago

@targos there is a eslint error related with the use of undefined. Could you check if I should refactor the function or test case.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (668cba6) 95.11% compared to head (9420cbc) 95.11%.

Files Patch % Lines
src/matrix/matrixSetSubMatrix.ts 95.83% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #211 +/- ## ======================================= Coverage 95.11% 95.11% ======================================= Files 168 169 +1 Lines 3334 3358 +24 Branches 832 844 +12 ======================================= + Hits 3171 3194 +23 - Misses 160 161 +1 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lpatiny commented 8 months ago

I don't see this error. The tests are passing correctly seems to me. Do you have the last version of the code ?

Also please add some tests of the throw. Do you see how to test errors ?