Dead code or bug in xNoiseSanPlot

mljs / spectra-processing

Various methods to help spectra processing

https://mljs.github.io/spectra-processing/

MIT License

7 stars 12 forks source link

Dead code or bug in xNoiseSanPlot #233

Open targos opened 4 months ago

targos commented 4 months ago

The variables assigned here are not used after the assignment:

https://github.com/mljs/spectra-processing/blob/5cd995e9226968d0a117761921a9d50262ac70c0/src/x/xNoiseSanPlot.ts#L160-L161

/cc @lpatiny @wadjih-bencheikh18 who worked on this code.

jobo322 commented 4 months ago

I transpile the code from Matlab Damien code. This multiplication appears in the original code but we do not export those initial values. It seems it was my fault