Fix swapped x and y dimensions in comments and variable names for MEPS data

mllam / neural-lam

Neural Weather Prediction for Limited Area Modeling

MIT License

102 stars 37 forks source link

Fix swapped x and y dimensions in comments and variable names for MEPS data #52

Closed joeloskarsson closed 3 months ago

joeloskarsson commented 3 months ago

The x- and y-dimensions for the MEPS data are swapped in comments describing tensor shapes, and also in some variable names. This change swaps from (x, y) ordering to the correct (y, x) ordering.

This fixes #46. See the issue for a more clear description.

leifdenby commented 3 months ago

LGTM as well! Thanks for this @joeloskarsson

sadamov commented 3 months ago

Ah yes this did confuse me back then :) thanks for fixing the comments!