search

mllg / batchtools

Tools for computation on batch systems
https://mllg.github.io/batchtools/
GNU Lesser General Public License v3.0
171 stars 51 forks source link

max.concurrent.jobs for array jobs #163

Closed mnwright closed 6 years ago

mnwright commented 6 years ago

If chunks.as.arrayjobs = TRUE and max.concurrent.jobs is used, it should be based on jobs not chunks.

Do we need a switch for chunks.as.arrayjobs = FALSE?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 94.429% when pulling 403e7a5d5664bd9ec01c772f5367dfe93cb92b8d on mnwright:master into 0a59699ace7942edc2e27525e9e92ac81a804c85 on mllg:master.

mllg commented 6 years ago

Yes, there must be a switch for chunks.as.arrayjobs. I've pushed a fix for this. Can you confirm that this works for you?

mnwright commented 6 years ago

Almost. * has higher precedence than !.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 93.945% when pulling bea76bb7a5e71bc1fc350da7edefa2a441e67eb3 on mnwright:master into e46ad5f965e4ac80b8733ae76e82104af19e55a8 on mllg:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 93.945% when pulling bea76bb7a5e71bc1fc350da7edefa2a441e67eb3 on mnwright:master into e46ad5f965e4ac80b8733ae76e82104af19e55a8 on mllg:master.

mllg commented 6 years ago

Ouch, right. Thanks. That was the precedence of C :cry:

mnwright commented 6 years ago

Thanks!