search

mllg / batchtools

Tools for computation on batch systems
https://mllg.github.io/batchtools/
GNU Lesser General Public License v3.0
171 stars 51 forks source link

unwrap() param name clash / allow prefix=TRUE again #167

Closed jakob-r closed 6 years ago

jakob-r commented 6 years ago

Can you allow unwrap() to have prefixes again to be able to distinguish between algo.par and prob.par.

Because:

  1. better compatibility with old evaluation skripts
  2. the following:
reg2 = makeExperimentRegistry(file.dir = NA)

addAlgorithm(reg = reg2, name = "test", function(data, job, instance, le.param) runif(1))
ades = list(test = data.frame(le.param = 1:10))

addProblem(reg = reg2, name = "test", data = "le data", fun = function(data, job, le.param) runif(1))
pdes = list(test = data.frame(le.param = letters[1:10]))

addExperiments(reg = reg2, prob.designs = pdes, algo.designs = ades)
unwrap(getJobPars(reg = reg2))
Error in unwrap(getJobPars(reg = reg2)) : 
  Name clash while unwrapping data.table: Duplicated column names: le.param
mllg commented 6 years ago

Does this work for you?

unwrap(getJobPars(reg = reg2), sep = ".")
jakob-r commented 6 years ago

Ah yes. rtfm.

Although it does not give the exact same result as before but that's manageable.