data.table Depends -> Imports

mllg / batchtools

Tools for computation on batch systems

https://mllg.github.io/batchtools/

GNU Lesser General Public License v3.0

170 stars 51 forks source link

data.table Depends -> Imports #246

Closed MichaelChirico closed 4 years ago

MichaelChirico commented 4 years ago

Thanks for using data.table! We noticed you are Depending on us and recently decided to strongly discourage downstream packages from doing so -- we think Imports is always better.

This PR attempts to make the migration from Depends to Imports for data.table.

If you have a strong reason for preferring Depends, we'd love to hear it over at our issue tracker:

https://github.com/Rdatatable/data.table/issues/3076

coveralls commented 4 years ago

Coverage decreased (-0.07%) to 87.488% when pulling fe76d4abf5095414836f59ce9aa2acbad8b192e5 on MichaelChirico:dt_import into ed75f6951a1603b2899b24ffb18b045190e8f863 on mllg:master.

mllg commented 4 years ago

Thanks for the PR. I'll try to release a new version within in the next 4 weeks.