search

mllg / checkmate

Fast and versatile argument checks
https://mllg.github.io/checkmate/
Other
265 stars 30 forks source link

Bug? `test_integerish(Sys.Date())` returns `TRUE` #223

Closed tdeenes closed 2 years ago

tdeenes commented 2 years ago

I think this is a similar issue to #164 and maybe qualifies as a bug.

In this line: https://github.com/mllg/checkmate/blob/5e35f452229b2a37536a4e21e1a6b6763fa45dc3/src/integerish.c#L61 it is only checked if the input inherits from "factor".

mllg commented 2 years ago

Thanks, now checking for Date and POSIXt.

lucasxteixeira commented 2 months ago

I think this also happens in test_numeric(Sys.Date())