search

mllg / checkmate

Fast and versatile argument checks
https://mllg.github.io/checkmate/
Other
261 stars 30 forks source link

change in behavior for assertIntegerish #226

Closed harvey131 closed 2 years ago

harvey131 commented 2 years ago

I would like to confirm that it was intentional that this behavior changed between 2.0.0 and 2.1.0

On 2.0.0 this would fail: checkmate::assertIntegerish(NA_character_, any.missing = T, all.missing = T)

But on 2.1.0 it will pass.

mllg commented 2 years ago

Yes, this is intended, but more like a side effect of a bugfix. In v2.0.0, checkmate complained about x being character, but checkmate usually does not type check on NA.