search

mllg / checkmate

Fast and versatile argument checks
https://mllg.github.io/checkmate/
Other
261 stars 30 forks source link

assertString(na.ok = TRUE) does not check whether NA is a character-type #236

Open avraam-inside opened 1 year ago

avraam-inside commented 1 year ago

checkmate::assertString(NA_real_, na.ok = TRUE)

there is no mistake - but there should be

salim-b commented 1 year ago

checkmate::assertString() and family are missing the typed.missing parameter that checkmate::assertNumeric() and family offer since https://github.com/mllg/checkmate/pull/199. Would be nice if typed.missing could be added to all relevant checkmate functions.