Fix testing for NA_REAL (fixes #258)

mllg / checkmate

Fast and versatile argument checks

https://mllg.github.io/checkmate/

Other

261 stars 30 forks source link

Fix testing for NA_REAL (fixes #258) #259

Closed tdeenes closed 1 month ago

tdeenes commented 5 months ago

As per the official docs, NA_REAL shall be tested with the ISNA macro.

This PR replaces all == NA_REAL idioms in the code base with ISNA. A new unit test has been added which fails without the current fix, and passes after the fix.

tdeenes commented 5 months ago

@mllg can you please take a quick look? This is a very simple bugfix.

mllg commented 1 month ago

Sorry for the late reply. Now merged and I will release a new version this week.