search

mllrsohn / grunt-invalidate-cloudfront

Sends a invalidation request to amazon cloudfront
MIT License
26 stars 13 forks source link

fix encodeURI to handle apostrophes in filenames #11

Closed bunnymatic closed 9 years ago

bunnymatic commented 9 years ago

Files that have apostrophes make the list for invalidation very unhappy. This should fix that by using the escape method on those left over strange characters.

Tests did not pass on the master branch and I'm not sure where I should be adding tests. I am using this in a current project, with great success.

steffenmllr commented 9 years ago

Thanks for the PR. There are not really tests for the project. It's quite old and I don't really use it anymore.

bunnymatic commented 9 years ago

Thanks for the merge.

I haven't done a lot of npm package work. When does this stuff make it's way into the npm repo?
That is, when can i safely change my other project package.json to use regular npm install instead of my fork?

Also, since you don't use this much anymore, is there a replacement? Or are you just not using cloudfront much so you don't need it?

steffenmllr commented 9 years ago

It is already published to npm (https://www.npmjs.com/package/grunt-invalidate-cloudfront) Just update the version number to 0.1.6 and run npm install

I've switched to gulp and use the offical aws sdk. But if grunt and the module works for you there is no reason to change something IMO.

bunnymatic commented 9 years ago

Great. thanks again for the merge, the deploy and the info.