search

mllrsohn / grunt-invalidate-cloudfront

Sends a invalidation request to amazon cloudfront
MIT License
26 stars 13 forks source link

Update peerDependencies to support Grunt 1.0 #15

Closed gruntjs-updater closed 8 years ago

gruntjs-updater commented 8 years ago

Update peerDependencies to support Grunt 1.0

Hello,

This is an automated issue request to update the peerDependencies for your Grunt plugin. We ask you to merge this and publish a new release on npm to get your plugin working in Grunt 1.0!

Read more here: http://gruntjs.com/blog/2016-02-11-grunt-1.0.0-rc1-released#peer-dependencies Also on Twitter: https://twitter.com/gruntjs/status/700819604155707392

If you have any questions or you no longer have time to maintain this plugin, then please let us know in this thread.

Thanks for creating and working on this plugin!

(P.S. Close this PR if it is a mistake, sorry)

mareksuscak commented 8 years ago

@steffenmllr @mllrsohn would you please consider accepting this PR and releasing a new version so we can depend on this package again?

jrbenito commented 8 years ago

Did anyone test this PR?

mareksuscak commented 8 years ago

@jrbenito we've upgraded to grunt 1.x and I believe it still works

mareksuscak commented 8 years ago

But of course, it whines about missing peer dependency so it would be cool if we could accept this PR and release a new version. Otherwise, we have to start depending on a namespaced fork.

steffenmllr commented 8 years ago

Sorry for taken so long. I don't use grunt anymore. @mareksuscak would you be interested in maintaining this module ?

mareksuscak commented 8 years ago

No problem @steffenmllr. I don't use grunt personally, too. Just my company uses it. I've seen some existing forks and the most up-to-date was https://github.com/jwalsh/grunt-invalidate-cloudfront so maybe @jwalsh could be interested in taking it over?

If he's not interested tho, I think I could take over and figure out a migration plan to some other grunt package and deprecate this one.

jwalsh commented 8 years ago

@steffenmllr @mareksuscak : There's a project I maintain that still uses this; I should be able to maintain it.

Will check out out the open PRs and issues...

steffenmllr commented 8 years ago

@jwalsh Great thank you! I've given you write access to this repo and publishing rights to npm