mllrsohn / gulp-protractor

gulp wrapper for protractor tests
MIT License
136 stars 82 forks source link

support --ignore_ssl in webdriver_update #126

Closed llwt closed 7 years ago

llwt commented 7 years ago

Currently there is no way to pass additional flags into the webdriver_update command. We are behind a corporate firewall and need to be able to specify the --ignore_ssl flag. The way the function is currently written makes it a bit hard to add that functionality without breaking changes, I was curious if you had any thoughts as to how to go about it? I would be more than happy to open a merge request.

rahulmr commented 7 years ago

There is a stupid solution or workaround if you want to try out. Report back if it works for you. Check example.

var webdriver_update = require('../').webdriver_update_specific;

// Downloads the selenium webdriver
gulp.task('webdriver_update', webdriver_update({
    browsers: ['ignore_ssl']
}));
rahulmr commented 7 years ago

Let us wait for PR #127 , your issue should be fixed and you can use code like below:

var webdriver_update = require('../').webdriver_update_specific;

// Downloads the selenium webdriver
gulp.task('webdriver_update', webdriver_update({
    webdriverManagerArgs: ['--ignore_ssl']
}));

I have checked it on windows and it works perfectly.

rahulmr commented 7 years ago

Sorry this is now implemented. Closing this issue.

llwt commented 7 years ago

@rahulmr Awesome, thanks!