search

mllrsohn / gulp-protractor

gulp wrapper for protractor tests
MIT License
136 stars 82 forks source link

Upgrade to protractor 6.x #143

Open EugeneSnihovsky opened 5 years ago

EugeneSnihovsky commented 5 years ago

Hello! Thanks for your work. I use your module for several years and it works like a charm.

For now 6x version is already released. Can you update protractor dependency or move it to peerDependency?

This line of code create separate gulp-protractor node_modules with protracotor 5x.

rahulmr commented 5 years ago

@EugeneSnihovsky Let me check it today.

rahulmr commented 5 years ago

@EugeneSnihovsky I checked and it seems it may break depending on many other things like gulp version, selenium version, etc So I feel will be better to create a separate branch, to do some tests first.

EugeneSnihovsky commented 5 years ago

@rahulmr Thanks for quick response. Maybe it make sense to move protractor dependency to peerDependency? In this case user will be able to choose protractor version by himself. But it will create breaking changes for your module (none protractor version will be installed automatically)

rahulmr commented 5 years ago

@EugeneSnihovsky If you can try including dependency for gulp-protractor as "gulp-protractor": "mllrsohn/gulp-protractor#protractor-v6", in your package.json file and let me know then it will be good. About peerDependency, it is possible I guess. The other thought I have is to put 1 async example with latest gulp 4.0.2 and protractor 6.0.0. I think that might be helpful.

EugeneSnihovsky commented 5 years ago

@rahulmr I spent some time for testing #protractor-v6 and here is results:

  1. My compilation prepublish scripts fail with same error as in this issue and seems that it still work in progress.
  2. For testing protractor 6.0.0 download selenium-webdriver version that requires Chrome version 76. For now this version is in beta and will be available on July 30

So until July 30 I will use protractor 5x and then check this issue again. Thanks for support and sorry for your lost time :)

EugeneSnihovsky commented 5 years ago

@rahulmr Hello! Sorry for long time with no response.

I check today protractor 6x again and I think it is still not stable. It has "selenium-webdriver": "^4.0.0-alpha.1" dependency. And for now it in alpha.4 and requires chrome v.77 that is still not released. So I think we need to wait for selenium-webdriver: 4.x stable version and then try again

richardstevens commented 4 years ago

Heya, is there any update on this as there are security issues now for it https://www.npmjs.com/advisories/1500