search

mllrsohn / gulp-protractor

gulp wrapper for protractor tests
MIT License
136 stars 82 forks source link

Gulp Protractor tests passing when it should fail #99

Closed karneaud closed 8 years ago

karneaud commented 8 years ago

I am using your plugin to do angularjs unit testing and refer to this thread

mattfritz commented 8 years ago

This should be fixed with the latest release, which updates Protractor to v3.2.2. There are several side effects when Protractor is installed as a project dependency instead of just using the version included with gulp-protractor, so removing protractor from devDependencies in your package.json is recommended.

https://github.com/mllrsohn/gulp-protractor/issues/101 will allow users to update Protractor without depending on gulp-protractor and should help with upgrades and problems like this. Let me know if removing the dependency and updating gulp-protractor does not solve the issue and I'll reopen this issue.