search

mloberg / Launch-Page

Create a viral launching soon page that integrates with MailChimp.
22 stars 8 forks source link

Moved API keys into secret.json so that it may be kept out of source control #2

Closed stevemcquaid closed 9 years ago

mloberg commented 9 years ago

Definitely agree with moving sensitive information like this out of source control. However, I think this application might be better off being rewritten. There's a lot of weird things being done here and it's not making use of composer or any type of framework.

stevemcquaid commented 9 years ago

I propose: 1) Merge this request 2) Create stable tag 3) Cut a dev branch 3) Create issues outlining the issues/user stories so that we can begin discussing framework and roadmap.

I love the simplicity of this project and look forward to working on it, whatever direction you think

mloberg commented 9 years ago

@stevemcquaid Ok. I'll work on that this weekend I think.

One suggestion for your PR is to have secret.json ignored by git and then have a secret.json.dist and instruct the user to copy the .dist file over and enter their credentials. Removing a file from git can sometimes be a hassle, especially when you get people that do git add .

stevemcquaid commented 9 years ago

Awesome!

Good call. Updating now

stevemcquaid commented 9 years ago

a87a447 <-- updated commit

mloberg commented 9 years ago

@stevemcquaid Check out #3 for v3 planning/discussion. I'm going to add some of my ideas later tonight, but if there was anything you wanted to add now, go for it.