search

mlocati / docker-php-extension-installer

Easily install PHP extensions in Docker containers
MIT License
4.18k stars 378 forks source link

Prevent problems while installing package #921

Closed jeff1326 closed 3 months ago

mlocati commented 3 months ago

Could you provide more details about this change? Why is it required?

jeff1326 commented 3 months ago

@mlocati Unfortunately no. My co-worker did the changes on a older version of this repository. He told me he added these almost everywhere until it works and he don't remember which specific package was causing the issue.

As i see this, this won't break anything at least.

tarlepp commented 3 months ago

That ACCEPT_EULA=Y sounds like mssql related configuration.

https://learn.microsoft.com/en-us/sql/linux/quickstart-install-connect-docker?view=sql-server-ver16&tabs=cli&pivots=cs1-bash#run-the-container-2

jeff1326 commented 3 months ago

That ACCEPT_EULA=Y sounds like mssql related configuration.

https://learn.microsoft.com/en-us/sql/linux/quickstart-install-connect-docker?view=sql-server-ver16&tabs=cli&pivots=cs1-bash#run-the-container-2

That would make sense since we use it in some projet

tarlepp commented 3 months ago

although that accept eula thing should not be happen if you're just installing pdo extension for that - not 100% sure about this.

mlocati commented 3 months ago

AFAIK the ACCEPT_EULA environment variable should be set to install msodbcsql in an unattended way. But we should already do that: msodbcsql is already being installed without any issue, isn't it?

I won't set a variable nobody knows why and when it should be set...