Why require PHP 7.2? - Githubissues

mlocati / spf-lib

PHP library to parse, build and validate SPF (Sender Policy Framework) DNS records

MIT License

54 stars 6 forks source link

Why require PHP 7.2? #19

Closed Sainan closed 3 years ago

Sainan commented 3 years ago

PHP 7.2 did not add that much functionality, so I was curious if this package actually needed it, so I installed PHP 7.1 (using your amazing powershell module), replaced the require-dev version constraints with "*", ran composer update, and the PHPUnit tests all ran fine:

mlocati commented 3 years ago

I'm not sure we can safely use this library on PHP 7.1: we should include code coverage in tests to be sure that tests touch as many PHP files as possible

mlocati commented 3 years ago

I'm not sure we can safely use this library on PHP 7.1: we should include code coverage in tests to be sure that tests touch as many PHP files as possible

Whoops... it's already implemented in this project (I guess I'm maintaining too many open source projects :wink:)