search

mlochbaum / CrinGraph

Bringing Crinacle's squiggly lines to your browser.
BSD Zero Clause License
100 stars 42 forks source link

Minor fixes and improvements #20

Closed MRSallee closed 2 years ago

MRSallee commented 2 years ago

A handful of small changes and bug fixes.

mlochbaum commented 2 years ago

Looks good, thanks. Weird to use a different URI encoder and decoder but after thinking about it that seems fine.

MRSallee commented 2 years ago

TBH I'm not very familiar with the distinction, but noticed that YouTube was breaking share links with multiple models in the share param because of commas, and switching to the different decoder when reading from the URL resolved it.

mlochbaum commented 2 years ago

I didn't know about it, but now that I do I expect it's common usage. encodeURI(',') is ',' so decodeURI won't decode it. And YouTube is doing some additional encoding it seems. Maybe the , would cause problems for a parser somewhere.