search

mlockett42 / litedb-async

This library allows the use of asynchronous programming techniques with the LiteDb library
Apache License 2.0
104 stars 13 forks source link

Change GetCollection return type to interface #16

Closed jspinner13 closed 3 years ago

jspinner13 commented 3 years ago

The current LiteDatabaseAsync.GetCollection method is not so easy to test. I would expect ILiteCollectionAsync instead of LiteCollectionAsync because the interface is mockable.

mlockett42 commented 3 years ago

Does this PR do what you want? https://github.com/mlockett42/litedb-async/pull/17

MKuckert commented 3 years ago

Are you planning to release a new nuget package containing this change?

mlockett42 commented 3 years ago

Yes in the next few days

On Fri, 20 Aug. 2021, 3:24 pm Martin Kuckert, @.***> wrote:

Are you planning to release a new nuget package containing this change?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mlockett42/litedb-async/issues/16#issuecomment-902491815, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMRPOLSCZAPZYW6Z23G2VLT5X7L7ANCNFSM5B3ZO66Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

mlockett42 commented 3 years ago

v0.0.10 containing this update just been pushed to nuget