Closed hopperelec closed 1 year ago
⚡ Preview for this PR: https://pr-72.chat-analytics.pages.dev 📊 Demo
Patch and project coverage have no change.
Comparison is base (
de8c517
) 74.08% compared to head (bd0dc6c
) 74.08%.:exclamation: Current head bd0dc6c differs from pull request most recent head 7945eb4. Consider uploading reports for the commit 7945eb4 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I'm confused why the code coverage changes so much, or even at all?
I'm not sure why the coverage did that 🤔 We should add tests to be sure the regex is working properly and to prevent regressions in the future. I'll add some later
It seems that the branch was in an old commit, I merged main to the PR. It should fix the coverage issue
Ohh, I updated the Git branch in my IDE, but forgot that it was fetching it from my fork of it which I hadn't synced on GitHub
I added a few tests, we can merge this :)
This regex is simpler and more lenient, and will perfectly match anything highlighted blue within Discord (some other platforms seem to be even more lenient than this, not even requiring http(s), which seems a bit over-the-top)
Fixes https://github.com/mlomb/chat-analytics/issues/71#issuecomment-1485946551