Closed hopperelec closed 11 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8bcf36e
) 71.93% compared to head (5350c3b
) 71.90%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
⚡ Preview for this PR: https://pr-95.chat-analytics.pages.dev 📊 Demo
By the way, what do you mean with "SPaG"? 🤔
By the way, what do you mean with "SPaG"? 🤔
Spelling, Punctuation and Grammar. Sorry, probably just a UK thing lol
I carefully checked all the changes and I'm ready to merge!
I added the following again:
fieldset {
display: grid;
display: contents;
}
Which was necessary for the Stepper (homepage, while processing) to display correctly.
I rolled back changes in BitStream
:
value >>>= 7; // from this
value = value >>> 7; // back to this
I don't recall correctly and can't find a source but I had problems with >>>=
in some browsers (iirc older but not dead versions of Safari), so I prefer to keep it that way
Thanks for your PR once again! Lot of work, thanks!! 🎊🎊🎊
Hm I did definitely test the stepper a lot and didn't see any issues, I don't know what having two display properties is supposed to do. Of will. But that older browser issue makes sense, no worries!
having two display properties is supposed to do
iirc it was a fallback
Edit: Didn't mean to include https://github.com/mlomb/chat-analytics/pull/94 in this, but I'll probably just cause issues with merging if I try to remove it