I left a more detailed explanation on discord - essentially, the removed comparison fails on Firefox, but passes on Chrome, due to chrome's StorageChange not preserving insertion order.
Note: the fact that the changeset object is still the same on Chrome, but only passes the condition due to changed property order, seems like it points to a bigger issue of 'what was this comparison trying to achieve' - not sure if removing it here causes any other side effects.
Tag reviewers for the PR below.
@mlool? not sure if there's a specific person i should be tagging here.
What Issue does this PR resolve? (Link to GitHub Issue, approved features and bugs will be given priority)
Fixes bug where 'Cancel' button doesn't do anything on Firefox (#68)
Please provide a video demo below, or a screenshot and description of the change.
Cancel button now actually removes course section:
https://github.com/mlool/workday-calendar-extension/assets/72814106/79f43b50-5925-4fc3-b05b-01d2d9b0dfbf
(To test this out I used the
firefox-manifest.jsonfrom #99)I left a more detailed explanation on discord - essentially, the removed comparison fails on Firefox, but passes on Chrome, due to chrome's
StorageChangenot preserving insertion order.Note: the fact that the changeset object is still the same on Chrome, but only passes the condition due to changed property order, seems like it points to a bigger issue of 'what was this comparison trying to achieve' - not sure if removing it here causes any other side effects.
Tag reviewers for the PR below.
@mlool? not sure if there's a specific person i should be tagging here.