refactor: minor UI bugfixes, refactor form - Githubissues

mlool / workday-calendar-extension

MIT License

60 stars 24 forks source link

refactor: minor UI bugfixes, refactor form #111

Closed ThatNerdSquared closed 2 months ago

ThatNerdSquared commented 2 months ago

What Issue does this PR resolve? (Link to GitHub Issue, approved features and bugs will be given priority)

PR implements the following...

minor UI bugfixes:

fixes bug where SectionPopup does not close when worklist is cleared
fixes bug where "Add Section" button is still clickable when no newSection exists
greys out "Cancel" and "Add Section" buttons when no newSection exists, using button's disabled attribute
prevent additional App rerender from useEffect updating currentTerm

code cleanups:

remove baseSection, making newSection nullable instead for clarity
rename invalidSection to sectionConflict for clarity on what 'invalid' means
move form action handlers to App to avoid needing to pass so many props down to Form
run prettier on Form.tsx (didn't run on the other files to avoid creating a huge diff)

Please provide a video demo below, or a screenshot and description of the change.

https://github.com/mlool/workday-calendar-extension/assets/72814106/e74c29d0-99f2-4dbd-a333-73ef6375f1f6

Tag reviewers for the PR below.

@mlool