Closed ThatNerdSquared closed 2 months ago
Couple nitpicks while we're refactoring
I know its unrelated but Can we add the same padding to the discord button as the rest of the settings?
As per the conversation we had on discord, I think everyone liked the idea of having the linked text in the section popup to say something like "<< View Course Page >>" Instead of having the code twice
Otherwise, i looked over everything and it looks great. Didnt observe any bugs or anything
Updated the section popup:
Not sure if it makes sense to have it in such large font compared to the course name - I think this info view could use a little styling cleanup but that will have to wait for another PR.
The settings padding is, unfortunately, inconsistent across elements. I've added some to the Discord button for now but that whole pane could use a styling cleanup at some point.
Also, I've included an updated yarn.lock
, as yarn tells me to run yarn install
when I build the extension for the first time. Let me know if this should be reverted.
What Issue does this PR resolve? (Link to GitHub Issue, approved features and bugs will be given priority)
This PR implements the following...
bugfixes/enhancements:
code cleanups:
ModalWindow
component:ConfirmationModal
(shown when "clear worklist" button is pressed)SectionPopup
(shown when sections are selected)InfoModal
(shown when users click question mark icons in settings)ModalLayer
wrapper component that manages showing all modals from a single top-level layermodalReducer
and then callingdispatchModal
using the provided contextForm.tsx
diff to see how it looks at the callsiteSettings.tsx
that is already present inTools.tsx
index.css
to reuse common colours, sizes, etcPlease provide a video demo below, or a screenshot and description of the change.
https://github.com/mlool/workday-calendar-extension/assets/72814106/a8b9b36e-f949-4b33-b80e-6e21e11a3c6c
Tag reviewers for the PR below.
@mlool NOTE:
SectionInfoBody.tsx
is really justSectionPopup.tsx
with some changes, and renamed - unfortunately there are enough differences that git thinks they're completely different files. Sorry about that.