mlool / workday-calendar-extension

MIT License
57 stars 22 forks source link

Cleanup, API Call & Setting Refactor, Import Modal Upgrade #131

Closed jaskirat-gill closed 4 weeks ago

jaskirat-gill commented 1 month ago

What Issue does this PR resolve? (Link to GitHub Issue, approved features and bugs will be given priority)

Please provide a video demo below, or a screenshot and description of the change.

Only visible change from UI Perspective demonstrated below

https://github.com/mlool/workday-calendar-extension/assets/60302907/c4a4db7e-6c94-4f3a-9f2d-e24eba22c642

Tag reviewers for the PR below.

jaskirat-gill commented 4 weeks ago

lgtm — some conflicts to be fixed though.

what conflicts? Dont see any on my end, lmk if any need to be fixing

ThatNerdSquared commented 4 weeks ago

nevermind, my github defaults to showing "Rebase and merge" instead of "Squash and merge" — ignore my comment lol 😅