mlool / workday-calendar-extension

MIT License
58 stars 22 forks source link

Users with 24-hour time set in preferences cannot add course sections #5

Closed david-mcpherson closed 5 months ago

david-mcpherson commented 5 months ago

The convertTo24 function assumes that the time will look like "9:30 a.m.", with an "a.m/p.m" suffix.

Here's the console error for users with 24 hour time: image

The solution is to make the "a.m/p.m" part of the regex optional: image

david-mcpherson commented 5 months ago

PR opened: https://github.com/mlool/workday-calendar-extension/pull/6