mloughran / em-hiredis

Eventmachine redis client
MIT License
221 stars 63 forks source link

Please update gem dependency: hiredis #15

Closed bry4n closed 12 years ago

bry4n commented 12 years ago

I was installing faye gem, but compiling failed.

gem install hiredis -v 0.3.2
Building native extensions.  This could take a while...
ERROR:  Error installing hiredis:
    ERROR: Failed to build gem native extension.

        /Users/bryann83/.rbenv/versions/ree-1.8.7-2011.03/bin/ruby extconf.rb
cc -std=c99 -pedantic -c -O3 -fPIC -Wall -W -Wstrict-prototypes -Wwrite-strings   -arch i386 -arch x86_64 -g -ggdb  net.c
clang: warning: argument unused during compilation: '-ggdb'
cc -std=c99 -pedantic -c -O3 -fPIC -Wall -W -Wstrict-prototypes -Wwrite-strings   -arch i386 -arch x86_64 -g -ggdb  hiredis.c
clang: warning: argument unused during compilation: '-ggdb'
hiredis.c:797:31: error: second argument to 'va_arg' is of incomplete type 'void'
                    va_arg(ap,void);
                    ~~~~~~~~~~^~~~~
/usr/bin/../lib/clang/3.1/include/stdarg.h:35:50: note: expanded from macro 'va_arg'
#define va_arg(ap, type)    __builtin_va_arg(ap, type)
                                                 ^
1 error generated.
make: *** [hiredis.o] Error 1
creating Makefile

details:

ruby -v

ruby 1.8.7 (2011-02-18 patchlevel 334) [i686-darwin11.3.0], MBARI 0x6770, Ruby Enterprise Edition 2011.03

brew info redis
redis 2.4.7
http://redis.io/
/usr/local/Cellar/redis/2.4.7 (9 files, 464K)

installed hiredis v0.4.4 without problem, but latest Faye is using >= em-hiredis v0.0.1 and em-hiredis is currently using ~> hiredis 0.3.2

I was not sure if ruby ree-1.8.7 is causing this, but work project is using ree-1.8.7 :-/

mloughran commented 12 years ago

I haven't heard any other reports of hiredis failing to compile, but thanks for alerting me that there's a 0.4.x. I will take a look at upgrading when I have some time (not likely this week...), in the meantime I suggest cloning and tweaking the gemfile if that works for you. /cc @pietern

pietern commented 12 years ago

This compilation error is caused by OSX defaulting to clang instead of gcc. I'll see if the same error happens on 0.4.

carlhoerberg commented 12 years ago

hiredis 0.4 compiles fine using clang.

mloughran commented 12 years ago

I've just released version 0.1.1 which updates hiredis and includes a few other minor things which have been sitting around in master for ages. Please let me know if there are any issues. Cheers :)

bry4n commented 12 years ago

Thanks. I'll check it out soon! :-)