search

mloughran / em-hiredis

Eventmachine redis client
MIT License
221 stars 63 forks source link

Push inactivity checks upstream #30

Closed mdpye closed 10 years ago

mdpye commented 10 years ago

Do you want to hand maintainership of this project on?

mloughran commented 10 years ago

Thanks!

It's a nitpick, but there's an assumption that the two timeouts are integers (if both were 0.3, a reconnect would occur before a ping). Probably worth asserting since you're already checking the arguments?

Does this make the tests run really slowly? I didn't check but it looks like it. Would it be easy to avoid?

Could you please write a little snippet for the readme on why one might want to use this?

R.e. maintainership - thanks for the offer but I'm ok continuing to look after this gem.

mdpye commented 10 years ago

Use .to_i on both test and usage? Best practices for asserting anything usefully safe in Ruby are still not clear to me ;)