search

mloughran / em-hiredis

Eventmachine redis client
MIT License
221 stars 63 forks source link

Support hiredis 0.6.0 #39

Closed romanbsd closed 8 years ago

romanbsd commented 9 years ago

It was recently released with no API changes as far as I can tell. https://github.com/redis/hiredis-rb/compare/v0.5.2...v0.6.0

jlecour commented 8 years ago

hiredis 0.6 has been around for quite some time (so it's used all over the place), and now that ActionCable (from Rails) is depending on em-hiredis we have a dependency conflict.

Bundler could not find compatible versions for gem "hiredis":
  In Gemfile:
    hiredis (~> 0.6)

    rails (= 5.0.0.beta1) was resolved to 5.0.0.beta1, which depends on
      actioncable (= 5.0.0.beta1) was resolved to 5.0.0.beta1, which depends on
        em-hiredis (~> 0.3.0) was resolved to 0.3.0, which depends on
          hiredis (~> 0.5.0)
badboy commented 8 years ago

Now that Rails seems to use it and the new version (0.6.1) works without problems on Windows (pure-Ruby-fallback), it might be nice to upgrade em-hiredis as well.

francesco-loreti commented 8 years ago

Yes please upgrade to 0.6.1 ...

skull-squadron commented 8 years ago

Master already bumped to 0.6.0.

Merging #48 and cutting a release would bump to 0.6.1 and close this.

skull-squadron commented 8 years ago

Ouch, it's still not actually fixed in released gems... GH might've interpreted "Fixes #xx" as an auto-closing verb. My bad.

mloughran commented 8 years ago

Yes I noticed that. Will get round to releasing in the next day or so. Actually having merged I think it's better to leave the dependency as ~> 0.6.0 so I'll revert before releasing. I don't think there's any reason to prefer 0.6.1, so better to leave the dependency loose. Thanks for the prod!

badboy commented 8 years ago

Only 0.6.1 will install flawlessly on Windows

sgrif commented 8 years ago

Just a note that this is still disrupting Rails. Can we cut a release soon?

mloughran commented 8 years ago

I have just released 0.3.1 which requires ~> 0.6.0. Hope this helps.

@badboy thanks – however keeping the dependency loose shouldn't cause issues; anyone running a clean bundle install or bundle update will get 0.6.1 assuming they have no other hard dependencies on 0.6.0.

skull-squadron commented 8 years ago

Woohoo. Least surprise FTW. Thanks.

On Wed, Jan 27, 2016 at 2:55 PM Martyn Loughran notifications@github.com wrote:

Closed #39 https://github.com/mloughran/em-hiredis/issues/39.

— Reply to this email directly or view it on GitHub https://github.com/mloughran/em-hiredis/issues/39#event-528906181.