search

mloughran / em-hiredis

Eventmachine redis client
MIT License
221 stars 63 forks source link

warnings when running Rails test suite (instance variable not initialized) #49

Open bronson opened 8 years ago

bronson commented 8 years ago

Seeing a lot of these when running the Rails 5 beta 2 tests:

/Users/bronson/.gem/ruby/2.2.2/gems/em-hiredis-0.3.1/lib/em-hiredis/base_client.rb:231: warning: instance variable @inactivity_timer not initialized /Users/bronson/.gem/ruby/2.2.2/gems/em-hiredis-0.3.1/lib/em-hiredis/base_client.rb:236: warning: instance variable @inactivity_trigger_secs not initialized

Easy workaround appears to be to put @inactivity_timer = @inactivity_trigger_secs = nil in BaseClient's initializer. Can submit a PR for that if you want.

bronson commented 8 years ago

test output: https://gist.github.com/bronson/2ab1261feef531c4fca3