Remove Fixnum deprecation warning (from ruby 2.4)

mloughran / em-hiredis

Eventmachine redis client

MIT License

221 stars 63 forks source link

Closed kalilz4485 closed 6 years ago

kalilz4485 commented 6 years ago

Hello

This MR does 2 things:

Remove the deprecation warning on Fixnum with ruby 2.4 (tested with ruby 2.4.1 & 2.5.1)
Limit rake version to keep rspec compatibility (when I bundled without I got an uncompatible version of rake wich led me here https://stackoverflow.com/questions/35893584/nomethoderror-undefined-method-last-comment-after-upgrading-to-rake-11)

Maybe this should be splitted in 2 different PR but i believed it's minor enough not to bother ^^"

mloughran commented 6 years ago

Thanks!

All the development dependencies probably should be upgraded at some point, but if this keeps things ticking all good.