search

mlp6 / fem

Finite Element Modeling (FEM) Code: Python Tools, Field II Intensity Field Solution, LS-DYNA Pre/Post Processing
Other
39 stars 15 forks source link

impulseResponse parameters #65

Open mlp6 opened 6 years ago

mlp6 commented 6 years ago

from @ndanieley 

"impulseResponse":
{
        "f0": 4000000.0,
        "phase": 0.0,
        "bw": 55.0,
        "wavetype": "gaussian"
},

I don't use any of those variables in my code, and as far as I can tell, you don't use them in the matlab code. am I missing something?

mlp6 commented 6 years ago

These parameters should be used by https://github.com/mlp6/fem/blob/master/field/defineImpResp.m. The parameters for impulseResponse were generated by the probe-specific Matlab calls in the old version (https://github.com/mlp6/fem/blob/2275487e50d5f31f242eb71042572bcf44644275/field/dynaField.m#L52).

That workflow has been changed (improved) in your new workflow, but there may be some redundant parameters in the original JSON probe definition files. When wavetype is gaussian, then an idealized impulse is generated from f0 and bw; if experimental, then there is the expected time/voltage data used from hydrophone measurements to define the impulse response.

ndanieley commented 6 years ago

hmmm. I don't see any place where f0 is used; at least, grep can't find it. I'll just proceed on the assumption that I don't need to read that part of the probe file unless we find an error.