Install Script for R - Githubissues

mlpack / benchmarks

Machine Learning Benchmark Scripts

101 stars 49 forks source link

Install Script for R #102

Closed Iron-Stark closed 7 years ago

Iron-Stark commented 7 years ago

@rcurtin

Actually I was thinking about adding all the R implementations to this PR itself. Please let me know if you think that we need to create a different PR for the implementations.

zoq commented 7 years ago

We should open a new PR for the implementations, right now we rebuild everything from scratch, since the PR modified the build script, which is slow.

Iron-Stark commented 7 years ago

@zoq

Sure. I'll do that for the other implementations. I was about to merge the QDA script too. Now I'll wait for this to merge and then will do the implementations in another PR. Should I remove the NBC ones from here or is it fine?

zoq commented 7 years ago

Let's keep the NBC script.

zoq commented 7 years ago

Nice work, easy merge!