search

mlpack / benchmarks

Machine Learning Benchmark Scripts
101 stars 49 forks source link

Fixes for logistic regression #109

Closed rcurtin closed 7 years ago

rcurtin commented 7 years ago

These fix a number of bugs I encountered while doing in-depth benchmarking of logistic regression. I have a new config also but that can come later.

zoq commented 7 years ago

@mlpack-jenkins test this

zoq commented 7 years ago

Can't comment on the file, anyway, https://github.com/mlpack/benchmarks/blob/73d236ed84368d37dce36ce9c903fb8b98f54ec7/methods/weka/src/LogisticRegression.java#L67 this should use: -T instead of -i, somehow we missed this before.

rcurtin commented 7 years ago

Wow, I did not realize I accidentally made this branch against the mlpack/benchmarks repository. Oops... next time I will not do that...

rcurtin commented 7 years ago

@mlpack-jenkins test this

rcurtin commented 7 years ago

Ok, I will go ahead and merge then.