search

mlpack / benchmarks

Machine Learning Benchmark Scripts
101 stars 49 forks source link

fix kmeans parameters #13

Closed Saurabh7 closed 8 years ago

Saurabh7 commented 8 years ago

Fix for kmeans script of shogun. Initial centers were not passed properly. http://www.shogun-toolbox.org/doc/en/latest/classshogun_1_1CKMeans.html#ad305d371488fa414e53c1347c391c480

zoq commented 8 years ago

There wasn't an option to set initial centroids in the last version we used for the benchmarks, so we came up with a simple solution. Take a look at: https://github.com/zoq/benchmarks/blob/master/methods/shogun/src/kmeans.cpp. Anyway, since we updated the version I guess, it's a good idea, to delete that file. Thanks for the contribution.

Saurabh7 commented 8 years ago

Oh I see, i didn't notice it because weirdly shogun wasnt throwing any error when RealFeature passed as argument even on my local machine. That needs to be fixed.

Yeah I think we can delete that file.