search

mlpack / benchmarks

Machine Learning Benchmark Scripts
101 stars 49 forks source link

Shogun benchmark for DecisionTree #36

Closed sam0410 closed 7 years ago

sam0410 commented 7 years ago

I will add the changes in benchmark_decision_tree.py as soon as the PR #24 is ready to merge. Thanks!

mlpack-jenkins commented 7 years ago

Can one of the admins verify this patch?

zoq commented 7 years ago

Can you write a simple test for the shogun benchmark script?

sam0410 commented 7 years ago

Hi @zoq ! I'll create it now. Also, I notice that there is no benchmark_test file for decision stump method. shall I create that too?

mlpack-jenkins commented 7 years ago

Can one of the admins verify this patch?

sam0410 commented 7 years ago

Hi @zoq ! I changed the files. Can you please review. Thanks for your patience.

zoq commented 7 years ago

@mlpack-jenkins test this

sam0410 commented 7 years ago

Hi @zoq ! Is there anything else I could add here? Thanks.

zoq commented 7 years ago

Looks absolutely fine, thanks for the great contribution!

sam0410 commented 7 years ago

Thanks for merging this @zoq :) I noticed that there is no benchmark_decision_stump file in tests, should I create one ?

zoq commented 7 years ago

Nice catch, would be great to see a test for the mlpack decision stump benchmark script.

sam0410 commented 7 years ago

Ok @zoq ,I created the PR for that. I also wanted to ask you if benchmarking in opencv library can be done. Thanks!