search

mlpack / benchmarks

Machine Learning Benchmark Scripts
101 stars 49 forks source link

Mrpt and Annoy benchmark for Approximate Nearest Neighbors #37

Closed Iron-Stark closed 7 years ago

mlpack-jenkins commented 7 years ago

Can one of the admins verify this patch?

zoq commented 7 years ago

@mlpack-jenkins test this

mlpack-jenkins commented 7 years ago

Can one of the admins verify this patch?

Iron-Stark commented 7 years ago

@zoq

Updated ann.py here in the same way as suggested in the annoy implementation. It should work fine now.

zoq commented 7 years ago

Thanks for the quick update. Btw. would be great if you could use a more descriptive commit message.

zoq commented 7 years ago

@mlpack-jenkins test this

Iron-Stark commented 7 years ago

@zoq

Will keep that in mind from now.

Iron-Stark commented 7 years ago

@zoq

The mrpt library expects float32 numpy arrays as inputs only and the SplitTrainData function was not returning that so I had to explicitly type cast the data being sent into float32 numpy arrays and now I have locally tested the code on the updated mrpt library and it is executing without any warnings

Iron-Stark commented 7 years ago

Please test this and review. This time it should compile without errors.

zoq commented 7 years ago

@mlpack-jenkins test this

zoq commented 7 years ago

Thanks again for the great contribution, I made some minor style fixes in ab37f16f2fa38dffc7c2d.