Added more options like min_samples_split,min_samples_leaf,max_features and max_nodes in Decision Tree scikit implementation

mlpack / benchmarks

Machine Learning Benchmark Scripts

101 stars 49 forks source link

Closed Iron-Stark closed 7 years ago

Iron-Stark commented 7 years ago

The methods/scikit/dtc.py was edited to include the mentioned features

mlpack-jenkins commented 7 years ago

Can one of the admins verify this patch?

mlpack-jenkins commented 7 years ago

Can one of the admins verify this patch?

rcurtin commented 7 years ago

Can you rebase this PR on the current git master branch? As is this would revert some changes like the annoy addition, etc.

Iron-Stark commented 7 years ago

@rcurtin

I have updated my fork and created a new PR (#43) for the same edit. Please Review.

rcurtin commented 7 years ago

Ok, I'll go ahead and close this one then.