Added more options like min_samples_split,min_samples_leaf,max_features and max_nodes in Decision Tree scikit implementation

mlpack / benchmarks

Machine Learning Benchmark Scripts

101 stars 49 forks source link

Closed Iron-Stark closed 7 years ago

Iron-Stark commented 7 years ago

@rcurtin

I have added this PR in place of PR(#39) after updating my fork. Please Review.

mlpack-jenkins commented 7 years ago

Can one of the admins verify this patch?

Iron-Stark commented 7 years ago

@zoq

Done. Please Review.

zoq commented 7 years ago

@mlpack-jenkins test this

Iron-Stark commented 7 years ago

@zoq

Not getting why the benchmark_ann file fails to compile here. Last time it was checked it compiled just fine.

Iron-Stark commented 7 years ago

It compiles without any warnings on my local system while working on the same branch.

zoq commented 7 years ago

@Iron-Stark Turns out the test sometimes fails when used with a small dataset, I'm not why. Let's see if testing on a bigger dataset helps.

zoq commented 7 years ago

@mlpack-jenkins test this

zoq commented 7 years ago

Another great contribution, thanks!

Iron-Stark commented 7 years ago

@zoq

Thanks. :) I am planning to implement approximate nearest neighbours using the NearPy library for the benchmarks . Will make a PR by tonight.