mlpack / benchmarks

Machine Learning Benchmark Scripts
101 stars 49 forks source link

Please include scikit-learn on Prerequesites #62

Open gut opened 7 years ago

gut commented 7 years ago

I thought I've installed all the prequesites but when running make setup:

[...]
byte-compiling ..//lib/python3.5/site-packages/mlpy/da.py to da.cpython-35.pyc
writing byte-compilation script '/tmp/tmp0e99ak1r.py'
/home/gut/venv/bin/python3 -OO /tmp/tmp0e99ak1r.py
removing /tmp/tmp0e99ak1r.py
running install_egg_info
Writing ..//lib/python3.5/site-packages/mlpy-3.5.0-py3.5.egg-info
Partial import of sklearn during the build process.
Traceback (most recent call last):
  File "setup.py", line 149, in get_scipy_status
    import scipy
ImportError: No module named 'scipy'
Traceback (most recent call last):
  File "setup.py", line 270, in <module>
    setup_package()
  File "setup.py", line 260, in setup_package
    .format(scipy_req_str, instructions))
ImportError: Scientific Python (SciPy) is not installed.
scikit-learn requires SciPy >= 0.9.
Installation instructions are available on the scikit-learn website: http://scikit-learn.org/stable/install.html

Partial import of sklearn during the build process.
Traceback (most recent call last):
  File "setup.py", line 149, in get_scipy_status
    import scipy
ImportError: No module named 'scipy'
Traceback (most recent call last):
  File "setup.py", line 270, in <module>
    setup_package()
  File "setup.py", line 260, in setup_package
    .format(scipy_req_str, instructions))
ImportError: Scientific Python (SciPy) is not installed.
scikit-learn requires SciPy >= 0.9.
Installation instructions are available on the scikit-learn website: http://scikit-learn.org/stable/install.html

Error installing scikit-learn!
Makefile:188: recipe for target '.setup' failed
make: *** [.setup] Error 1

a pip install scipy scikit-learn cython seems to solve this kind of issues. Swig also needed to be installed (but it's not a python module, so I sudo apt install'ed it).

zoq commented 7 years ago

I guess you mean to list scipy as a prerequisite, since make setup downloads the packages and installs the libs (including scikit-learn). Nevertheless, I think listening all prerequisites for all libs is a good idea, despite it might be difficult to keep everything updated.

gut commented 7 years ago

well, the README.md file should be kept as up-to-date as possible right? :-)

zoq commented 7 years ago

Definitely, I will add/update a section about the dependencies for each library. I'm wondering if we could come up with a script that checks for the dependencies and informs the user about missing packages.