search

mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
35 stars 41 forks source link

Remove travis configuration #10

Closed rcurtin closed 4 years ago

rcurtin commented 4 years ago

Similar to mlpack/mlpack#2416.

kartikdutt18 commented 4 years ago

Hey @rcurtin, Sorry I missed the change here. It doesn't seem like we are running travis.yml here. Should that be the case? I mean like the travis ci test doesn't show up in the checks.

birm commented 4 years ago

I guess so long as we have a travis file, it makes sense to fix it, but the fix to CI was done by @kartikdutt18 and merged in at https://github.com/mlpack/models/commit/c9054c0efe4437178dae6a931f513fe313319927#diff-ff1640c467ee5600fecc42cf57a6e2adR25

rcurtin commented 4 years ago

@kartikdutt18 it's true, but I figured it was good to change it anyway. :)

kartikdutt18 commented 4 years ago

Ahh, makes sense. Thanks a lot for the clarification.

rcurtin commented 4 years ago

Actually, after some quick discussion in the video chat, it seems better to just remove the configuration entirely. So I did that. :)