mlpack-bot[bot]
commented
4 years ago Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:
- All code should follow the style guide
- Documentation added for any new functionality
- Tests added for any new functionality
- Tests that are added follow the testing guide
- Headers and license information added to the top of any new code files
- HISTORY.md updated if the changes are big or user-facing
- All CI checks should be passing
Thank you again for your contributions! :+1:
Some of the decisions here on wrapping are questionable. I'll revisit if someone doesn't do so first :)