Closed kartikdutt18 closed 4 years ago
This works on windows too now, Cleaning commits and outputs.
(Probably we should get mnist_test/train in mnist.tar.gz since mnist test and train are fixed).
Sure, we can do that, is there anything else you like to add here, this looks pretty good to me.
Sure, we can do that, is there anything else you like to add here, this looks pretty good to me.
I am done with this PR from my side aside from placing mnist_train/test in mnist.tar.gz. If this makes sense I'll ask on the IRC once I incorporate all suggestions.
Makes sense to me.
Looks good to me as well, please let us know if this is ready to go :)
This is ready from my side. Just tested it everything works fine. I think the builds will result in the same output. Regards.
Sorry pushed in the wrong branch, reverting now. Fixed now.
Great. Thanks a lot for the reviews.
Thanks! @kartikdutt18 👍
Thanks @KimSangYeon-DGU, @zoq for the reviews and all the help.
This PR is transferred from #8, Since FFN weights some time cause invalid memory access which seems related to mlpack/mlpack#2314. So I am adding utility function to unzip files here and I'll continue working on image dataloader and then we can get back to the LeNet model. I hope this makes sense. This PR provides the following :
Looking forward to your suggestions. Regards.
CC: @KimSangYeon-DGU