mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
35 stars 41 forks source link

Restructuring 2 - Add Utility functions and Run all Tests #12

Closed kartikdutt18 closed 4 years ago

kartikdutt18 commented 4 years ago

This PR is transferred from #8, Since FFN weights some time cause invalid memory access which seems related to mlpack/mlpack#2314. So I am adding utility function to unzip files here and I'll continue working on image dataloader and then we can get back to the LeNet model. I hope this makes sense. This PR provides the following :

  1. Unzip Utility Function.
  2. Some bug fixes.
  3. Runs all tests. (Probably we should get mnist_test/train in mnist.tar.gz since mnist test and train are fixed).
  4. ListDir Utility function.

Looking forward to your suggestions. Regards.

CC: @KimSangYeon-DGU

kartikdutt18 commented 4 years ago

This works on windows too now, Cleaning commits and outputs.

zoq commented 4 years ago

(Probably we should get mnist_test/train in mnist.tar.gz since mnist test and train are fixed).

Sure, we can do that, is there anything else you like to add here, this looks pretty good to me.

kartikdutt18 commented 4 years ago

Sure, we can do that, is there anything else you like to add here, this looks pretty good to me.

I am done with this PR from my side aside from placing mnist_train/test in mnist.tar.gz. If this makes sense I'll ask on the IRC once I incorporate all suggestions.

zoq commented 4 years ago

Makes sense to me.

KimSangYeon-DGU commented 4 years ago

Looks good to me as well, please let us know if this is ready to go :)

kartikdutt18 commented 4 years ago

This is ready from my side. Just tested it everything works fine. I think the builds will result in the same output. Regards.

kartikdutt18 commented 4 years ago

Sorry pushed in the wrong branch, reverting now. Fixed now.

kartikdutt18 commented 4 years ago

Great. Thanks a lot for the reviews.

KimSangYeon-DGU commented 4 years ago

Thanks! @kartikdutt18 👍

kartikdutt18 commented 4 years ago

Thanks @KimSangYeon-DGU, @zoq for the reviews and all the help.