search

mlpack / models

models built with mlpack
https://models.mlpack.org/docs
BSD 3-Clause "New" or "Revised" License
35 stars 41 forks source link

Image Dataloader with Field type #18

Closed kartikdutt18 closed 4 years ago

kartikdutt18 commented 4 years ago

This is nearly the same PR as the other image dataloader. Difference is that I have used field vector inserting bounding boxes. So in preprocessing of dataset for model we would have instant lookups.

zoq commented 4 years ago

This is nearly the same PR as the other image dataloader. Difference lies that I have used field vector inserting bounding boxes. So in preprocessing of dataset for model we would have instant lookups.

So I guess we can close the other one?

KimSangYeon-DGU commented 4 years ago

@zoq Yes, we can close the other one if this is better :) We're currently seeing if which approach is better between this and #13.

kartikdutt18 commented 4 years ago

do you think we could provide a simple notebook to show how this code can be used to augment some image dataset?

Sure I can give it a try, This would be for examples repo or model repo? Thanks.

KimSangYeon-DGU commented 4 years ago

@kartikdutt18 I think this is ready to be merged. Can you squash the commits to be concise?

kartikdutt18 commented 4 years ago

Sure. Let me do that right now.

kartikdutt18 commented 4 years ago

Pushing a commit to delete the dataset.

zoq commented 4 years ago

do you think we could provide a simple notebook to show how this code can be used to augment some image dataset?

Sure I can give it a try, This would be for examples repo or model repo? Thanks.

I think it makes sense to put it into the examples repository, super excited to see this merged.

KimSangYeon-DGU commented 4 years ago

@kartikdutt18 Thanks for the amazing work!

kartikdutt18 commented 4 years ago

Thanks a lot @KimSangYeon-DGU, @zoq, @saksham189 for the reviews and all the help.